Update blocktracker and tracker to provide synchronous API

[sergerad]

Changes

• Update blocktracker and tracker APIs to be synchronous
• Remove logger from blocktracker
• Handle ignored error
• Update blocktracker to return subscription cancellation errors
• Update unit tests

Why?

Pkg API funcs should return errors they encounter, rather than log them. This allows the caller to decide what to do on error and means we don't leak logging impl/semantics into ethgo (e.g. [ERROR] prefix).

See https://github.com/golang/go/wiki/CodeReviewComments#synchronous-functions

Usage goes from

// This runs a goroutine for us and does not return all errors from its stack
tracker.Sync()

to

go func() {
    // This goroutine receives all errors from Sync stack, we decide what to do with those errors
    err := tracker.Sync()
}

Alternative Impl?

Could keep the funcs asynchronous and update them to return a channel of errors. More complicated, more side effects

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ethgo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 21, 2023 9:04pm

[sergerad]

This error was being ignored completely

[sergerad]

@ferranbt could you please take a look at this PR. My biggest concern is the unhandled error

[paulgoleary]

bump @ferranbt @vcastellm

[ferranbt]

Please check the CI.

[paulgoleary]

The test that seems to be failing here, TestFilterIntegration does not fail for me locally.

pauloleary@Pauls-MacBook-Pro-3 ethgo % go test -v -run TestFilterIntegration ./tracker
=== RUN   TestFilterIntegration
--- PASS: TestFilterIntegration (3.97s)
PASS
ok  	github.com/umbracle/ethgo/tracker	4.159s

Not sure what the CI problem could be?

[sergerad]

@paulgoleary thanks for taking a look. Sorry I have been out sick all week. Hoping to be back online tomorrow to look at this 🙏

[paulgoleary]

re-bump @ferranbt @vcastellm

[vcastellm]

LGTM