Fix tracker errors after a block reorganization #247
Merged
+32
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is when reorganization occurs on chain, so the parent block does not exist any more. function
handleReconcileImpl()
should check if the obtained block isnil
(parent == nil
):parent, err := t.provider.GetBlockByHash(block.ParentHash, false)
There are some additional places in
blocktracker.go
and tracker.go which should be handled also. They are introduces in this PR as well.