Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to worry about domains? #8

Closed
PeteDuncanson opened this issue Aug 29, 2018 · 2 comments
Closed

Do we need to worry about domains? #8

PeteDuncanson opened this issue Aug 29, 2018 · 2 comments
Assignees

Comments

@PeteDuncanson
Copy link
Contributor

A little early to be worrying about this now but something that might need some thought. If I bind a node to a domain and then hit that domain's GraphQL endpoint do I only get back that domains data or can I traverse the whole tree and other root nodes?

@rasmusjp
Copy link
Collaborator

One way to handle this could be by adding some new fields to the root query e.g.

site: PublishedContent: the "site" content (where the domain is configured)
contentByUrl(url: String!): PublishedContent: found by url, restricted to the "site"

That way you'll still be able to get all the content at root by using contentAtRoot

@rasmusjp rasmusjp self-assigned this Sep 19, 2018
rasmusjp added a commit that referenced this issue Sep 20, 2018
@PeteDuncanson
Copy link
Contributor Author

PR for this is open #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants