Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karma needs to be restructured #193

Closed
nul800sebastiaan opened this issue Mar 23, 2018 · 3 comments
Closed

Karma needs to be restructured #193

nul800sebastiaan opened this issue Mar 23, 2018 · 3 comments
Labels
status/stale Marked as stale due to inactivity type/feature

Comments

@nul800sebastiaan
Copy link
Member

Currently Karma exists in a few different tables and we can't create new types of Karma to hand out (for example for merged PRs #192).

Querying is also expensive as we need to join all the data from the tables making it slow.

Would be good to merge all of this in one single table with a karma category.
Eventually this will require a bit of a maintenance window on Our to freeze the site, consolidate the data and then start the site again. We need a good plan for this.

It might also be good to index karma data i n Examine so we don't have to reach out to the database all the time.

@warrenbuckley
Copy link
Contributor

@nul800sebastiaan not sure I follow but a member has total karma in the index - as long as its not too expensive to calculate then it could be added to the Examine Index

@nul800sebastiaan
Copy link
Member Author

Yeah, I'm not sure if we need to know the breakdown of karma categories.

Mostly we should just have 1 table in the DB for it though.

@umbrabot
Copy link

Hiya @nul800sebastiaan,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version 8.9.0

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@umbrabot umbrabot added the status/stale Marked as stale due to inactivity label Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/stale Marked as stale due to inactivity type/feature
Projects
None yet
Development

No branches or pull requests

3 participants