Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to sort columns in list view #10307

Closed
Wiggee11 opened this issue May 21, 2021 · 8 comments · Fixed by #10351
Closed

Unable to sort columns in list view #10307

Wiggee11 opened this issue May 21, 2021 · 8 comments · Fixed by #10351

Comments

@Wiggee11
Copy link

Wiggee11 commented May 21, 2021

Which Umbraco version are you using?

8.13.0

Bug summary

The icon to drag and drop columns to sort them in a custom list view editor window are invisible and so you can't sort columns.

If you inspect the HTML, the svg icons are there but they have no width or height and so don't appear and can't be selected.

Giving them a width and height they appear and work as expected.

list view sort

Specifics

No response

Steps to reproduce

Edit a custom list view and try to order the columns.

Expected result / actual result

No response


This item has been added to our backlog AB#12101

@nul800sebastiaan
Copy link
Member

Thanks @Wiggee11, I can reproduce this and it used to work in 8.12, so I'll mark this as a regression bug we should look at. I think it must have something to do with switching to SVG icons. Strange that it does work on the Layouts list below that, they're also SVGs. 🤔

@nul800sebastiaan nul800sebastiaan added state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks status/regression labels May 25, 2021
@Wiggee11
Copy link
Author

It also works fine editing a list view Data Type directly.

@nul800sebastiaan
Copy link
Member

Ah that's a good workaround, thanks for highlighting that!

@nul800sebastiaan nul800sebastiaan added state/in-sprint We've committed to work on this during the sprint indicated in the milestone and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks labels May 26, 2021
@nul800sebastiaan nul800sebastiaan added this to the sprint164 milestone May 26, 2021
@bjarnef
Copy link
Contributor

bjarnef commented May 28, 2021

@nul800sebastiaan I think this has already been fixed in v8/contrib branch.
#10036

image

@nul800sebastiaan
Copy link
Member

@bjarnef That's the workaround. The problem is when you try to do this on the document type > list view content app:

image

@nathanwoulfe
Copy link
Contributor

I'm guessing the issue with the SVG icons is they don't have dimensions defined. Not an issue for icon fonts because they'll inherit font-size, but SVG will need explicit height and width.

@bjarnef
Copy link
Contributor

bjarnef commented May 28, 2021

Ahh okay, will have another look. Not sure why it need to set width to zero here.

image

@bjarnef
Copy link
Contributor

bjarnef commented May 28, 2021

Fixed in #10351

@umbrabot umbrabot removed the state/in-sprint We've committed to work on this during the sprint indicated in the milestone label Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants