Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification when editor creates Url collision with multilingual content #10350

Closed
FransdeJong opened this issue May 28, 2021 · 5 comments
Closed
Labels
project/v9 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks status/stale Marked as stale due to inactivity type/feature

Comments

@FransdeJong
Copy link
Contributor

FransdeJong commented May 28, 2021

Umbraco version

v9

Description

I've run into a situation where a page in a live website kept dropping out of the cache.
After a lot of debugging we finally found out what happened:

To reproduce the issue we ran into you need to do the following.

In a new Umbraco project create two languages, say dutch and english
Create a rootnode variable by culture and save and publish it only in dutch.
Under the rootnode create a node that is not varying by culture, call it for example about and publish it.

In my case the editor published the rootnode in english without telling me

The about page now periodicly starts dropping from the cache. If you reload memory cache it's back up and there is no notification why it dropped from cache.

Solution:
There are multiple solutions to this issue:

  1. Prevent publishing a rootnode when there is no culture and hostname set. This could however cause issues when Umbraco is only used as a data store (headless).
  2. Add a warning popup that warns the editor to contact the dev
  3. Report issues when reloading cahce/publishing the about node or another trigger so we can find the issue.

Myself and @HamDerAndrew lost quite some time indentifying this one.


This item has been added to our backlog AB#13848

@bergmania
Copy link
Member

bergmania commented Jun 1, 2021

Hi @FransdeJong ..

When you say "Live website", I guess this is relevant for v8, and not v9 as described in the "Umbraco version".?

Or do I miss something? Can you be more specific about the version by including a minor number too?

@FransdeJong
Copy link
Contributor Author

Hi @bergmania,

I encountered this in V8.12.2. The reason for picking V9 is that the feature request template forces you to choose in what version you propose the request to be added. Since V9 is around the corner I thought this doesn't need to be added to V8.

So I encountered this in V8. Not sure if it's a bug or it works as designed therefor I picked new feature.

@bergmania bergmania added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Sep 10, 2021
@nikolajlauridsen
Copy link
Contributor

Hey @FransdeJong, I've started looking into this, but can you perhaps provide a little more information so I can try and reproduce the scenario as accurately as possible, mainly:

Which language was set as the default language, English, or Dutch? And how was the domains on the root node set up?

@FransdeJong
Copy link
Contributor Author

Dutch was the default language. There was no domain set since the site wasn't multilingual yet.

@umbrabot
Copy link

umbrabot commented Apr 5, 2022

Hiya @FransdeJong,

Just wanted to let you know that we noticed that this issue got a bit stale and might not be relevant any more.

We will close this issue for now but we're happy to open it up again if you think it's still relevant (for example: it's a feature request that's not yet implemented, or it's a bug that's not yet been fixed).

To open it this issue up again, you can write @umbrabot still relevant in a new comment as the first line. It would be super helpful for us if on the next line you could let us know why you think it's still relevant.

For example:

@umbrabot still relevant
This bug can still be reproduced in version x.y.z

This will reopen the issue in the next few hours.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@umbrabot umbrabot added the status/stale Marked as stale due to inactivity label Apr 5, 2022
@umbrabot umbrabot closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project/v9 state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks status/stale Marked as stale due to inactivity type/feature
Projects
None yet
Development

No branches or pull requests

4 participants