Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11921: Update CultureName after language change #12055

Merged

Conversation

BElluu
Copy link
Contributor

@BElluu BElluu commented Feb 24, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

I implement fix to this issue #11921 . After fix, notification display correct language name :)

Description

After changing the language option "swedish" to "dutch" it does use the dutch language for the pages but when you publish a page the notification popup at the bottom says "Content published: Swedish (Sweden) published and visible on the website" whilst it should be referring to "dutch (netherlands)".

Steps to reproduce:

  1. Change the swedish language option to Dutch (netherlands) and save.
  2. Publish a page in the changed language.

image

@umbrabot
Copy link

umbrabot commented Feb 24, 2022

Hi there @BElluu, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Feb 26, 2022

Thanks @BElluu for this PR, it works all good 👍
The confirmation message will be less confusing now, which is always good 😁

And since this is your first contribution to Umbraco, @nul800sebastiaan will gladly assign you a shiny contributor badge 🎉

Thanks again and I'm looking forward to reviewing your next contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants