Adding null check to IsCulturePublished on IContent

[callumbwhyte]

Currently if you pass null into IsCulturePublished it throws an ArgumentNullException - this is because (rightfully) the publishedInfos dictionary cannot contain null keys. Passing an empty string for the culture instead returns false. It seems to have been this way since V8.

Many of the other methods on IContent that take a culture defend against this, e.g. GetCultureName, so I found it weird that this method didn't. For now I have just added a null check in my package when calling the method.

This PR adds a NullOrWhitespace check on the culture before checking the dictionary to prevent any issues.

[umbrabot]

Hi there @callumbwhyte, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[mikecp]

Thanks for this PR @callumbwhyte, the check is indeed more robust like this 👍

Just out of curiosity, did you already encounter actual situations where this was null?

Cheers and thanks again!

[mikecp]

FYI: failing tests do not seem to be linked to the changes in this PR.

[callumbwhyte]

Thanks @mikecp!

My specific use case was needing to lookup this information inside a ValueEditor, where the culture param is optional and defaults to null.

[mikecp]

Thanks @callumbwhyte for the details 😉