Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Tree Node Not Greyed Out When Unpublished. #12279

Closed
marcloveUSN opened this issue Apr 20, 2022 · 8 comments · Fixed by #13253
Closed

Content Tree Node Not Greyed Out When Unpublished. #12279

marcloveUSN opened this issue Apr 20, 2022 · 8 comments · Fixed by #13253

Comments

@marcloveUSN
Copy link

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

8.18.3 - 9.4.3

Bug summary

With our uSkinned Site Builder we like to predefine Document Types and fields that should vary by culture so that if a customer decides to have a multi-lingual website all they need to do is add their languages and define hostnames for the website.

If you have a Document Type that is set to vary by culture along with a field that is set to vary by culture, when you unpublish the node in the content tree it is NOT greyed out.

The file attached will install a Home node with the correct settings so that you can test this issue.
Vary_by_culture_issue_1.0.0.zip

Specifics

No response

Steps to reproduce

Please install the attached package in Umbraco 8 to replicate this issue.

Expected result / actual result

No response

@nul800sebastiaan
Copy link
Member

Thanks for the report, I can also reproduce this in v8.14. It seems to have something to do with only one language being installed, at which point it doesn't really make sense to mark fields / doctypes as vary by culture. Though I can see that in your use case for providing starter kits, it would make sense to be ready for multilingual setup if people want them. The problem seems to be something to do with the time that ( and ) is added around the home node, indicating this language has no name yet I think?

Weirdly, once I added a language it started working and when I deleted the language it worked again as well, even after an app pool recycle and deleting everything + the package and reinstalling the package. Seems like a small edge-case somewhere but I can't put my finger on exactly where.

In any case, we'd love some help to get this fixed! Currently the new target is v10/contrib and if the fix is small and safe then I'm sure we can easily backport it to 9 and maybe even 8.

@umbrabot
Copy link

umbrabot commented May 4, 2022

Hi @marcloveUSN,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post

Thanks muchly, from your friendly Umbraco GitHub bot :-)

@marcloveUSN
Copy link
Author

Hi Seb, thanks for taking a look. Any guidance on where to look in the source code?

@nul800sebastiaan
Copy link
Member

The only sensible thing I could say about it was this: > seems to be something to do with the time that ( and ) is added around the home node

Not sure where that happens exactly though 🙈

@marcloveUSN
Copy link
Author

Okay, if you get any further info on this, let me know. I will see if I can dig into the issue and figure out why its happening.

@bourpie
Copy link

bourpie commented Jun 26, 2022

Hello, I'm having this issue with Umbraco version 9.2.0.

Someone suggested on the Forum creating a class that hook into the tree render event (Umbraco 8)
https://our.umbraco.com/forum/using-umbraco-and-getting-started/109307-unpublished-status-unpublished-class-not-set-in-the-tree-view#comment-109307

@vlaellayug
Copy link
Contributor

Hi @nul800sebastiaan, @marcloveUSN, @bourpie - I've created a PR for this issue.

@bourpie
Copy link

bourpie commented Oct 21, 2022

That is great news. Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants