Umbraco 9.4.3 search issue

[pramodbhagat]

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

9.4.3

Bug summary

The Search function doesn't work as it always returns 0

Specifics

Hello,

We're building a new site using Umbraco 9.4.3 and we have identified a bug with below Search function doesn't work.

IEnumerable<PublishedSearchResult> Search(IQueryExecutor query, int skip, int take, out long totalRecords);

totalRecords gives the correct count but it always return 0 records where as I would have expected IEnumerable<PublishedSearchResult>

We have tested a fresh DB with Umbraco 9.4.3 and 9.5 and this doesn't work however when I downgrade Umbraco it to 9.3.1 then it works.

Would be good to have a fix or a workaround until we have a fix.

Thanks,
Pramod

Steps to reproduce

With a fresh install of Umbraco 9.4.3 or 9.5 when you call Search function this always returns 0 items where as the out parameter totalItems does returns the total item count.

Expected result / actual result

I would have expected an IEnumerable list of PublishedSearchResult as a return type.

[matthewcare]

Hi @pramodbhagat, I hope you're doing well :)

I've opened up a PR to fix your issue. In the meantime a workaround would be to not use IPublishedContentQuery
Since you're already using an IQueryExecutor, you can instead also inject IPublishedSnapshotAccessor

With your variable name searchQuery you will be able to do

_publishedSnapshotAccessor.TryGetPublishedSnapshot(out var publishedSnapshot);
var queryResults = searchQuery.Execute(new QueryOptions(0, 12));
var totalResults = queryResults.TotalItemCount;
var publishedContentResults = queryResults.ToPublishedSearchResults(publishedSnapshot);

I hope this still helps, even if it is a little late

[martin-rhodes]

I hope this still helps, even if it is a little late

Not too late for me, who also just stumbled across this nasty little bug! This workaround has helped get the site search back up and running without too much fuss though, so thanks for sharing!

[craigs100]

Have also run into this on V10.0.1. TotalCount correct but records always 0.

Ref: https://our.umbraco.com/forum/using-umbraco-and-getting-started/109441-paged-search-with-iqueryexecutor-problem

@mathewcare 's workaround worked for me.

[pramodbhagat]

Hi @pramodbhagat, I hope you're doing well :)

I've opened up a PR to fix your issue. In the meantime a workaround would be to not use IPublishedContentQuery Since you're already using an IQueryExecutor, you can instead also inject IPublishedSnapshotAccessor

With your variable name searchQuery you will be able to do

_publishedSnapshotAccessor.TryGetPublishedSnapshot(out var publishedSnapshot);
var queryResults = searchQuery.Execute(new QueryOptions(0, 12));
var totalResults = queryResults.TotalItemCount;
var publishedContentResults = queryResults.ToPublishedSearchResults(publishedSnapshot);

I hope this still helps, even if it is a little late

Hi @matthewcare,
Good to hear back from you. Hope you're well.

Thanks for responding and this does work for me.

Thanks,
Pramod

[nul800sebastiaan]

FYI: This is on the list for HQ to review and merge, thanks @matthewcare for the PR!

[Zeegaan]

Fixed in #12612