Package migration state is not correctly displayed/updated in the backoffice

[sergiutesu]

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

10.1.0

Bug summary

After running the package migration successfully, the button still shows as there are pending changes.

More about the Package Migration Settings here:
https://our.umbraco.com/documentation/Reference/Configuration/PackageMigrationSettings/

Specifics

The default for PackageMigrationsUnattended is true and I don't have any other setting in my project to change it.

The setting doesn't have a default value in the schema: it's missing the DefaultValue attribute on the property:

Umbraco-CMS/src/Umbraco.Core/Configuration/Models/UnattendedSettings.cs

Lines 38 to 44 in e626fca

	/// <summary>
	/// Gets or sets a value indicating whether unattended package migrations are enabled.
	/// </summary>
	/// <remarks>
	/// This is true by default.
	/// </remarks>
	public bool PackageMigrationsUnattended { get; set; } = true;

Steps to reproduce

1. Install a completely new Umbraco v10.1.0 locally & spin it up
2. Install Forms (I used NuGet package manager for that)
3. Go to the packages section and click on "Run pending package migration"
   

It will say it is successful.

Going back to the packages section the button will still show as pending.

Expected result / actual result

The button should be disabled or not there since there is nothing pending.

---

This item has been added to our backlog AB#24992

[PriceyCoder]

I have also had this issue since at least v10.0.1.
It is still happening with Umbraco v10.2 and UmbracoForms 10.1.2
It occurred with both UmbracoForms and uSync.

[ghost]

I also see this for the packages I have installed, even in 10.3.2.

[kjac]

@sergiutesu thank you for raising this issue - and I'm sorry it took us so long to respond to it.

I have reproduced it and submitted a fix in #13574 😄

For future reference, this is a regression issue caused by this commit.

[nikolajlauridsen]

Fixed in #13574, thanks for reporting 😄