UmbracoHelper.GetDictionaryValue defaults to en-US when used in non-front end code

[philipdanielhayton]

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

10.1.0

Bug summary

Calling umbracoHelper.GetDictionaryValue('') is always returning results from the en-US culture, even though that culture doesn't exist in my language settings. In my particular use case it manifests itself by returning empty strings.

I am accessing umbracoHelper using IUmbracoHelperAccessor inside a service that is triggered by administrators in the Umbraco back end (specifically, sending emails using Vendr). This particular service is registered as a transient, but the issue also occurs if registerd as a singleton.

I have tried changing the default culture on the thread but that doesn't seem to do anything.

It may be possible that I'm missing something obvious, however it also raises a potention enhancement - should there be an overload method that lets you pass in a specific culture, such as:

umbracoHelper.GetDictionaryValue("MyKeyName", "en-GB") ?

In any case I am exploring accessing the ILocalizationService as a work around, but this just feels like a bug.

Specifics

No response

Steps to reproduce

Create a transient or singleton service and try accessing dictionary values other than en-US.

Expected result / actual result

For example when:

• en-GB is the default language for the site
• The dictionary key "Greeting" has a value of "Hey there"

I would expect calling umbracoHelper.GetDictionaryValue("Greeting") to return "Hey there", but it actually returns an empty string.

[github-actions]

Hi there @philipdanielhayton!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[uppercuut]

fixed at #12942

[nikolajlauridsen]

Hey @philipdanielhayton sorry about the long turn around, but #12942 has now been merged, with the overload you specified 🎉 so I'll go ahead and close this issue for now :D Thanks again for reporting