Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid property editors not loading after Umbraco 10.2.0 update #12994

Closed
RGV2ZWxvcGVy opened this issue Sep 14, 2022 · 4 comments
Closed

Grid property editors not loading after Umbraco 10.2.0 update #12994

RGV2ZWxvcGVy opened this issue Sep 14, 2022 · 4 comments

Comments

@RGV2ZWxvcGVy
Copy link

RGV2ZWxvcGVy commented Sep 14, 2022

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.2.0.67

Bug summary

After updating Umbraco from version 10.1.1 to version 10.2.0 I encountered an issue with some of the Grid editors.
In particular editors that use the Doc Type Grid Editor are not loading correctly anymore. I know this package has been marked as retired, but in Umbraco 10.1.1 it is still working properly.

Specifics

I am using Umbraco Cloud version 10.2.0.67, and when creating a new page, there are now 2 buttons that lets you add content (in the previous version there was only one). When I choose a Grid component that uses the Doc Type Grid Editor to add content, a AngularJS error shows up in the console, and my property editors won't load.

This is the exact error message:
TypeError: Cannot read properties of undefined (reading 'variants') at $scope.propertyEditorDisabled (umbraco.directives.min.js?d=637987433650000000:1:112602) at fn (eval at compile (angular.js:16548:15), <anonymous>:4:301) at angular.js:11489:57 at r (angular.js:396:9) at Da (angular.js:11396:7) at p (angular.js:10613:30) at g (angular.js:9942:13) at angular.js:9807:30 at angular.js:10221:16 at d (angular.js:9985:16) '<div class="controls" ng-transclude="">'

I guess it has to do with this issue. Umbraco Forms had a patch releases yesterday. But I guess Doc Type Grid Editor won't release a patch for this as it is deprecated. Maybe someone has a quick workaround for this?

Steps to reproduce

  1. Install Our.Umbraco.DocTypeGridEditor v10.0.0 from NuGet, and build your project (make sure your running version 10.2.0 of Umbraco).
  2. Create a Document Type in the backoffice, so you can create a root node/page (make sure this Document Type has a property with the 'Grid layout' data type so you can use the Grid).
  3. Create another Document Type as Element Type with some properties (data type doesn't matter).
  4. Create a (root)page in the Content section, choose 'Headline' or 'Article'.
  5. Two buttons should appear to add new content, click on one of the buttons, and choose 'Doc Type'.

Your Document Type marked as Element Type should appear without the actual property editors showing up.

Expected result / actual result

After step 5 the expected result is the properties would correctly load the property editors of the corresponding data types.
The actual result is the property editors not loading correctly, and an error message in the console of the browser.

Below some screenshots of the issue:
Screenshot_6
Screenshot_7
Screenshot_8


This item has been added to our backlog AB#22612

@github-actions
Copy link

Hi there @RGV2ZWxvcGVy!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan
Copy link
Member

This seems more related, with the same error: leekelleher/umbraco-contentment#250

@lassefredslund lassefredslund added the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Sep 15, 2022
@RGV2ZWxvcGVy
Copy link
Author

I see that there is a new version of the package available: https://our.umbraco.com/packages/backoffice-extensions/doc-type-grid-editor/ :)
This fixes the issue, so I will close this ticket.

@iOvergaard
Copy link
Contributor

Hey everyone, we are going to fix it on a more general level in the upcoming 10.2.1 patch: #13060

@iOvergaard iOvergaard removed the state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants