Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setDirty() logic to remove actions on mediaPicker3 property editor #13085

Merged
merged 1 commit into from Nov 28, 2022
Merged

add setDirty() logic to remove actions on mediaPicker3 property editor #13085

merged 1 commit into from Nov 28, 2022

Conversation

Bakersbakebread
Copy link
Contributor

@Bakersbakebread Bakersbakebread commented Sep 30, 2022

Addresses issue #13009

Fixes #13009

the setDirty() logic was missing from remove-able actions, this PR adds them

@github-actions
Copy link

github-actions bot commented Sep 30, 2022

Hi there @Bakersbakebread, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@nul800sebastiaan nul800sebastiaan changed the base branch from v10/contrib to v11/contrib October 25, 2022 13:00
@nul800sebastiaan nul800sebastiaan merged commit 3377a7c into umbraco:v11/contrib Nov 28, 2022
@nul800sebastiaan
Copy link
Member

Excellent @Bakersbakebread - does what it says on the tin! 👍 Thanks for the help!

@nul800sebastiaan
Copy link
Member

Ps. FYI Leaving Fixes #1234 from the PR template in place helps to auto-link issues and PRs, so I wouldn't have to manually close the related issues. I've added that now to make the link happen.

image

@nul800sebastiaan
Copy link
Member

Cherry picked for 10.4.0 ded4424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing a media item doesn't prompt changes were made
2 participants