Accessibility Fixes for Users and Packages pages

[KarlButler1]

Prerequisites

• I have added steps to test this contribution in the description below

This is related to the Accessibility issue here: #12546

If there's an existing issue for this PR then this:

• Fixes Packages - Skipped heading level(s) Umbraco-CMS.Accessibility.Issues#51
• Fixes Add user - Skipped heading level(s) Umbraco-CMS.Accessibility.Issues#69
• Fixes Add user - Missing form labels Umbraco-CMS.Accessibility.Issues#68

Description

Fixes included in this PR:

1. Fixes umbraco/Umbraco-CMS.Accessibility.Issues#51 (Packages - Skipped heading level(s))

What did you do and why ?

• Updated the h4 headings to be h2 to follow the heading hierarchy and applied styling to these so they matched the current headings

How to test ?

• Go to the Packages page, and run the Accessibility Insights - Chrome Extension to check that no errors are shown for skipped headings

2. Fixes umbraco/Umbraco-CMS.Accessibility.Issues#69 (Add User - Skipped heading level(s))

What did you do and why ?

• Updated the h3 headings to be h2 to follow the heading hierarchy and applied styling to these so they matched the current headings

How to test ?

• Go to the Users - Create User page, and run the Accessibility Insights - Chrome Extension to check that no errors are shown for skipped headings

3. Fixes umbraco/Umbraco-CMS.Accessibility.Issues#68 (Add User - Missing form labels)

What did you do and why ?

• Updated code to apply the correct "for" identifier to point to the form field and add id to form field to link the label and form fields together

How to test ?

• Go to the User - Create User page, and run the Accessibility Insights - Chrome Extension to check that no errors are shown for missing form labels

[github-actions]

Hi there @KarlButler1, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[KarlButler1]

Hi @BatJan, thanks for the feedback !

I've just corrected this in the latest commit 🙂

[BatJan]

Hey @KarlButler1 - Awesome :-) Cheers!

[umbrabot]

Hi there @KarlButler1!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 18th, 2022, 09:00 AM UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

[nul800sebastiaan]

Apologies for the delay @KarlButler1 but this is great work and I enjoyed learning about the Accessibility Insights extension as well! This all checks out and is ready to go.

Thanks again! #h5yr!

[nul800sebastiaan]

Cherry picked for 10.4.0 303abae