Fixes umbraco/Umbraco-CMS.Accessibility.Issues#39

[bkclerke]

Prerequisites

• I have added steps to test this contribution in the description below

This fixes umbraco/Umbraco-CMS.Accessibility.Issues#39
Related to: V9: Fix A & AA accessibility issues throughout Backoffice #12546

Description

What did you do?
Added the aria-labelledby attribute to the umbraco tags property editor input.

Why did you do it?
The umbraco tags property editor input was failing WCAG Level AA compliance since the input was missing a label. The label for the property editor already existed, it just needed to be linked up to the input that constantly updates as a user adds or removes tags.

Screenshot prior to fix:

Screenshot after fix:

How to test the changes:

1. Install v10
2. Install Paul Seal Clean Starterkit Package
3. Navigate to Home Content Node
4. Click SEO Tab
5. Use WAVE Evaluation Tool Plugin to verify tags input is no longer missing label.
6. Turn on Windows Accessibility Narrator and open backoffice to tab through the properties on the SEO tab. The tags field is described correctly.

[github-actions]

Hi there @bkclerke, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[bkclerke]

PR for this issue in V11: umbraco/Umbraco-CMS#13324
Related discussion on the original issue.

[umbrabot]

Hi there @bkclerke!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 18th, 2022, 09:00 AM UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

[nul800sebastiaan]

Thanks @bkclerke - this is looking good! I'm going to merge this one (which I already had to retarget to v11) and close the other "v11" PR. I am not entirely sure what we're doing with backporting fixes from v11 to v10, but I think this would make a good candidate. I'll update when I know if we're backporting to v10.

[nul800sebastiaan]

Cherry picked for 10.4.0 ae31c2f