Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddManifestFilter extension method to UmbracoBuilder.CollectionBuilders.cs #13161

Conversation

erikjanwestendorp
Copy link
Contributor

@erikjanwestendorp erikjanwestendorp commented Oct 11, 2022

In addition to: #11691 . It would be nice to add a ManifestFilter directly from the Startup.cs class.

@github-actions
Copy link

github-actions bot commented Oct 11, 2022

Hi there @erikjanwestendorp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@erikjanwestendorp erikjanwestendorp changed the base branch from v10/contrib to v11/dev October 19, 2022 07:07
@erikjanwestendorp erikjanwestendorp changed the base branch from v11/dev to v10/contrib October 19, 2022 07:08
@nul800sebastiaan nul800sebastiaan changed the base branch from v10/contrib to v11/contrib October 25, 2022 12:53
@nul800sebastiaan nul800sebastiaan merged commit 65dd52a into umbraco:v11/contrib Nov 28, 2022
@nul800sebastiaan
Copy link
Member

Great idea @erikjanwestendorp, thanks for this one! 👍

nul800sebastiaan pushed a commit that referenced this pull request Dec 14, 2022
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.4.0 77fdcf2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants