Packages Modal - Further Fixes for Modal Trap

[KarlButler1]

Prerequisites

• I have added steps to test this contribution in the description below

Related to issue: Fix A & AA accessibility issues throughout Backoffice

If there's an existing issue for this PR then this fixes:

• umbraco/Umbraco-CMS.Accessibility.Issues#61 (Package Details - Image Modal - Missing Modal Trap)

Description

What did you do and why ?

• Updated the focus trap when the modal is open so the user is only able to navigate to the elements of the modal (and not outside onto the browser)

How to test ?

• Go to the Packages page, and use the tab key to navigate through the page to the images, when on an image click enter and open up the Image Modal
• Once open use the TAB key to navigate through the elements in the modal check that the focus stays in the modal and doesn't allow the user to navigate the package page.

[github-actions]

Hi there @KarlButler1, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[mikecp]

Hi @KarlButler1 ,

Thanks for working further on the issue and providing this new fix. I have tested it out and indeed the focus remains solely within the modal window now 👍

I did notice that, when closing the modal by clicking the enter key on the top left "X", the modal closes but focus does not come back on the image which opened the modal anymore. Could you maybe check if you have the same behavior?

Cheers!

[mikecp]

Thanks @KarlButler1 for updating quickly again 👍

I tested and this time it all works as expected, so we can merge it (again😅 ) !🎉🎉

I hope you won't mind, but II took the liberty to change the hardcoded color in the .less file by the closest ".less variable color", which was named ui-outline, so I guess it's relatively appropriate 😁

Thanks again for your work on this!

Cheers!