Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added h2 for the package details heading #13273

Conversation

tiffy74
Copy link
Contributor

@tiffy74 tiffy74 commented Oct 22, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes Package details - Skipped heading level(s) #59

Description

Fixed skipped heading on the package details page

Navigate to 'Packages' section
Open a package (e.g. Umbraco forms)
Heading levels now read correctly

The 'visual heading' was not configured as a heading:

<div class="umb-packages-view-title ng-binding ng-scope">Umbraco Forms</div>

image

Now is changed to:

<h2 class="umb-packages-view-title ng-binding ng-scope">Umbraco Forms</h2>

image

This heading is unique to the package description page so there does not appear to be any adverse effect elsewhere. As the classes for the div have been used on the heading - there has not been any impacts on styling either on desktop or mobile sizes

@github-actions
Copy link

github-actions bot commented Oct 22, 2022

Hi there @tiffy74, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Oct 28, 2022

Thanks @tiffy74 for this new accessibility improvement 👍

@nul800sebastiaan
Copy link
Member

Cherry picked for 10.4.0 90fdd8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package details - Skipped heading level(s)
3 participants