Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11Y added missing iframe title to installer and preview controller. #13278

Merged
merged 1 commit into from Oct 25, 2022

Conversation

RachBreeze
Copy link
Contributor

In order to support accessibility iframe elements should have titles on them (Ref https://www.w3.org/WAI/WCAG21/Techniques/html/H64).

I have added the titles for the iframes in the preview controller and the YSOD area of the installer.

@github-actions
Copy link

github-actions bot commented Oct 23, 2022

Hi there @RachBreeze, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Oct 24, 2022

Hi @RachBreeze ,
Thanks for this addition 👍
I was wondering if it would also make sense to make those titles localizable?
Cheers!

@RachBreeze
Copy link
Contributor Author

Hi @mikecp

I did wonder about this but the install screen isn't localised, and the preview screen had this markup in it <div class="menu-bar__title">Preview Mode</div>

Cheers

Rachel

@nul800sebastiaan
Copy link
Member

We could make them localized though! But let's do that in a separate PR ✅

Thanks @RachBreeze!

@nul800sebastiaan
Copy link
Member

Cherry picked for 10.4.0 5d0d245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants