Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Roots are H1 #13314

Conversation

tiffy74
Copy link
Contributor

@tiffy74 tiffy74 commented Oct 27, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes User management - Coded as H1 but different to other H1s seen on site #64

Description

Sections across the backoffice had a variety of different headings

Previously, if the tree root contained a group it would be tagged with a heading of H1. If the tree root contains multiple groups, then the items would be coded as H5. This resulted in some sections having H5 as the main heading.

This has now been changed so that all tree root headings are H1 and styled the same

Log into Umbraco
Browse to any of the sections
The top level heading in the sidebar should always be H1

image

@github-actions
Copy link

github-actions bot commented Oct 27, 2022

Hi there @tiffy74, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@tiffy74
Copy link
Contributor Author

tiffy74 commented Oct 28, 2022

I wasn't sure if this would cause a problem if there were multiple tree nodes. It doesn't according to my tests.

@tiffy74 tiffy74 marked this pull request as ready for review October 28, 2022 16:01
@mikecp
Copy link
Contributor

mikecp commented Dec 10, 2022

Thanks @tiffy74 for harmonizing the tree-view titles display 👍
It seems to work all fine indeed 😁

@nul800sebastiaan
Copy link
Member

Cherry picked for 10.4.0 4dbd7de

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User management - Coded as H1 but different to other H1s seen on site
3 participants