Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created an add current domain button to the cultures and hostnames sc… #13436

Merged
merged 2 commits into from Nov 25, 2022

Conversation

prjseal
Copy link
Contributor

@prjseal prjseal commented Nov 17, 2022

PR done at the Umbraco Together Hackathon.

This PR adds a feature to the Cultures and Hostnames screen

The feature is a button which adds the current domain as a hostname.

addcurrentdomain

If the URL is using a port other than 80 or 443 then it appends the port too, otherwise it just uses the host.

image

@prjseal prjseal marked this pull request as ready for review November 17, 2022 16:43
@prjseal
Copy link
Contributor Author

prjseal commented Nov 23, 2022

@nul800sebastiaan any update on this one? Do you think we can get it into the full v11 release?
It's very small and simple

@nul800sebastiaan
Copy link
Member

Didn't get to it for v11.0.0 I'm afraid, but this is a great candidate for 11.1.0! 👍

@mikecp
Copy link
Contributor

mikecp commented Nov 25, 2022

Thanks @prjseal for this addition, it's a nice shortcut 😁🎉
Cheers!

@mikecp mikecp merged commit d86d298 into umbraco:v11/contrib Nov 25, 2022
@prjseal
Copy link
Contributor Author

prjseal commented Dec 2, 2022

@mikecp do you think this could be cherry picked for v10?

@mikecp
Copy link
Contributor

mikecp commented Dec 2, 2022

Hey @prjseal , I guess it could, but it's up to @nul800sebastiaan to decide 😉
Cheers!

nul800sebastiaan pushed a commit that referenced this pull request Dec 14, 2022
#13436)

* created an add current domain button to the cultures and hostnames screen

* removed unwanted space

(cherry picked from commit d86d298)
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.4.0 5db507c

@prjseal
Copy link
Contributor Author

prjseal commented Dec 14, 2022

Cherry picked for 10.4.0 5db507c

Woohoo thanks @nul800sebastiaan

a-t-k pushed a commit to a-t-k/Umbraco-CMS that referenced this pull request Jan 6, 2023
umbraco#13436)

* created an add current domain button to the cultures and hostnames screen

* removed unwanted space

(cherry picked from commit d86d298)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants