Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster full nucache table rebuild #13501

Merged

Conversation

nzdev
Copy link
Contributor

@nzdev nzdev commented Nov 30, 2022

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Optimize queries for rebuilding nucache when using SQL Server / SQL Azure / SQL Lite.
The rebuild queries time out when deleting existing nucache data on rebuild.
If all the cmsContentNu records will be deleted, truncates the table instead of running the deletes.

How to test?
Rebuild nucache on SQL Server, SQL Azure, SQL Lite

@nzdev nzdev changed the title SQL Server Truncate when full nucache SQL rebuild. Faster full nucache table rebuild Nov 30, 2022
@nul800sebastiaan nul800sebastiaan changed the base branch from v11/contrib to contrib January 26, 2023 14:48
@georgebid georgebid self-requested a review March 9, 2023 11:05
@georgebid georgebid merged commit be72c81 into umbraco:contrib Mar 9, 2023
2 of 5 checks passed
@georgebid
Copy link
Contributor

Hi @nzdev, thanks so much for your pull request to fix #12278
It has now been successfully merged!

@georgebid georgebid added community/pr category/performance Fixes for performance (generally cpu or memory) fixes type/feature release/11.3.0 labels Mar 9, 2023
nul800sebastiaan pushed a commit that referenced this pull request Mar 17, 2023
* SQL Server Truncate when full nucache SQL rebuild.

* Optimize truncate for SQL Lite

* Remove comment.

* Use current DB Types

* I added a couple of formatting changes.

---------

Co-authored-by: georgebid <91198628+georgebid@users.noreply.github.com>
(cherry picked from commit be72c81)
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.5 in 1241401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants