Check if PublishedPropertyType modelType is null #13553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonElkin
requested changes
Mar 7, 2023
There was a problem hiding this comment.
Thanks so much @CyberReiter for taking a look at this.
Though this is a bug/problem with the Property Value Converter, we don't really want to throw here because we can gracefully fall back to typeof(object).
Strictly speaking, there's no need for a Property Value Converter for a given property, hence the fallback, so it makes sense to treat a null type the same way we would when there is no converter at all.
If you're happy to change it to return typeof(object) (I've added an example) that would be amazing, otherwise let me know and I can do it and we'll get this fix merged in ASAP.
src/Umbraco.Core/Models/PublishedContent/PublishedPropertyType.cs
Outdated
Show resolved
Hide resolved
JasonElkin
approved these changes
Mar 8, 2023
1 task
nul800sebastiaan
pushed a commit
that referenced
this pull request
Mar 17, 2023
* add null check * return object when type is null (cherry picked from commit 0cfc1fb)
|
Cherry picked for 10.5 in 5fcbd4e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's an existing issue for this PR then this fixes #13515
Description
Adding a null check for the modeltype right after the PropertyValueConverter has been called to check if a type has been set.
That the type returned is null should never happen when using default PropertyValueConverters but if you are using a custom PropertyValueConverter there could be a chance that null is returned.
Sadly we only have the Id of the datatype available, but thats still better than nothing.