Use ISO codes instead of language IDs for fallback languages and translations #13751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmania
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Found a small issue I fixed while testing.
I was able to create languages with an invalid fallback culture. The fallback culture was saved as null.
Now I added now more state in LanguageOperationStatus.
I think this is mainly a Mac Issue (maybe also windows) and It looks like most short iso codes, are faked as valid. For longer codes, it fails like expected
…de-take-two # Conflicts: # src/Umbraco.Core/CompatibilitySuppressions.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
As the API is moving away from referencing entities by IDs, it's getting harder and harder to use the language IDs currently exposed for fallback language and translation language identification. This PR refactors those usages so we use language ISO codes as identifiers instead.
The management API contract remains unchanged by these changes, as it is already using ISO codes 😄
However, with these changes applied, the current backoffice is no longer able to set nor display language fallbacks. Dictionary items can still be created and edited as per usual.
Breaking changes⚠️
This PR introduces breaking changes. Another PR has been created to flag these changes in V11 - see #13753.
Testing this PR
Test this PR by:
As a minimum this needs to be tested through the management API (get in touch with @kjac for Postman collections). It would be prudent to test this in the current backoffice as well, to the extend it is possible.