Listview batch publishing on multi language site, publishes all variants #13755 - Fix #13772
Conversation
…dded model and modified the javascript function that call the api endpoint.
|
Hi there @mennomout, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
|
Hi @mennomout , I had a quick look at it and I would suggest to create a separate controller method for this scenario, and then to handle in the Javascript part which one will be called, depending on whether or not you have cultures specified: no culture => call as now, specific culture => new method. I was also wondering how the "cultures" param was sent through to the Javascript method since you don't seem to be modifying the caller(s) to that function, but this is probably because I did not actually run you solution locally yet 😅 I'll make sure to check in details later, but I thought it was already worth mentioning those two points. Cheers! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…tment to js function.
|
@mikecp I've made some changes based on your suggestions. Please let me know if there is anything else I can do to improve the PR. |
|
Hi @mennomout , Thanks for the update, it looks less complex in this new version, and it is also non breaking 😉 👍 It all works fine but I left a few suggestions that might improve performances a bit, let me know if they seem OK to you. Cheers! |
…hByIdAndCulture. Added parameter to ngDoc. Added Where Query.
|
@mikecp I've implemented your suggested changes. Thank you again for the feedback! |
|
Thanks a lot @mennomout for the adaptations! And congratulations on your first contribution to the Umbraco CMS 🎉 And now we'll be looking forward to your next PR"s 😁 Cheers! |
|
@mikecp Thank you for the kind words and assistance with this PR! @nul800sebastiaan My OurUmbraco profile is: https://our.umbraco.com/members/mennomout/ |
|
Badge added @mennomout - thanks again and congrats! 🏅 |
|
Wonderful job @mennomout! Glad to see your first contribution merged into the source-code! |
|
Thank you both @nul800sebastiaan and @cornehoskam! |
…nts #13755 - Fix (#13772) * Modified PostPublishById to handle content that is culture variant. Added model and modified the javascript function that call the api endpoint. * Added separate method for publishing with cultures. Added if else statment to js function. * Moved check for all cultures being published to the top of PostPublishByIdAndCulture. Added parameter to ngDoc. Added Where Query. (cherry picked from commit 37db3ae)
|
Cherry picked for 10.5 in 273e770 |
Prerequisites
Fixes: #13755
Description
Modified
PostPublishByIdto handle content that is culture variant. Added a new model for the endpoint and modified the JavaScript function that calls said endpoint.I've tested these changes by creating a new doctype with list view enabled. I've allowed another doctype as it's child. Both doctypes are culture variant. After these changes you can publish one culture from the list view and the other culture will remain unpublished. I'd like someone else to test these changes as well. There were a few occasions where it looked like it wasn't working but I wasn't really able to replicate that.
See gif below for the result:
