Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special characters in avatar [part 2] #13796

Conversation

erikjanwestendorp
Copy link
Contributor

In addition to #13766

This PR updated the regex to remove special charachters as suggested by @ronaldbarendse #13766 (comment)

The regex has Unicode mode enabled now.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Hi there @erikjanwestendorp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

…avatar.directive.js

Co-authored-by: Ronald Barendse <ronald@barend.se>
@erikjanwestendorp
Copy link
Contributor Author

@ronaldbarendse Thanks for your suggestion, just updated the PR.

@mikecp
Copy link
Contributor

mikecp commented Feb 8, 2023

Thanks @erikjanwestendorp for the quick update and thanks @ronaldbarendse for the check 👍🎉

Cheers!

@mikecp mikecp merged commit 280fbdd into umbraco:contrib Feb 8, 2023
@erikjanwestendorp erikjanwestendorp deleted the regex-unicode-to-remove-chars-from-avatar branch February 8, 2023 11:57
@mikecp
Copy link
Contributor

mikecp commented Feb 8, 2023

@nul800sebastiaan I labelled it to release 11.2.0 because the original PR was merged just before closing 11.2.0. So I hope this one can get squeezed in 😁🤞

@nul800sebastiaan
Copy link
Member

Ah thanks @mikecp - unfortunately the RC was already built and ready to ship, it will just be an update in the next minor instead, what is implemented now should work fine for the next few months! 👍

@mikecp
Copy link
Contributor

mikecp commented Feb 10, 2023

So you DID get it in 11.2.0 🎉😂

image

@nul800sebastiaan
Copy link
Member

lol! no.. something went wrong here..

image

Now with the correct labelling it should not show up on the 11.2 release any more (after cache refreshes in about an hour 😅 )

@mikecp
Copy link
Contributor

mikecp commented Feb 10, 2023

People will be so disappointed... 😂

nul800sebastiaan pushed a commit that referenced this pull request Mar 16, 2023
* Update regex

* Update src/Umbraco.Web.UI.Client/src/common/directives/components/umbavatar.directive.js

Co-authored-by: Ronald Barendse <ronald@barend.se>

---------

Co-authored-by: Ronald Barendse <ronald@barend.se>
(cherry picked from commit 280fbdd)

# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/components/umbavatar.directive.js
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.5 in aacac49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants