New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special characters in avatar [part 2] #13796
Remove special characters in avatar [part 2] #13796
Conversation
Hi there @erikjanwestendorp, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
src/Umbraco.Web.UI.Client/src/common/directives/components/umbavatar.directive.js
Outdated
Show resolved
Hide resolved
…avatar.directive.js Co-authored-by: Ronald Barendse <ronald@barend.se>
@ronaldbarendse Thanks for your suggestion, just updated the PR. |
Thanks @erikjanwestendorp for the quick update and thanks @ronaldbarendse for the check 👍🎉 Cheers! |
@nul800sebastiaan I labelled it to release 11.2.0 because the original PR was merged just before closing 11.2.0. So I hope this one can get squeezed in 😁🤞 |
Ah thanks @mikecp - unfortunately the RC was already built and ready to ship, it will just be an update in the next minor instead, what is implemented now should work fine for the next few months! 👍 |
People will be so disappointed... 😂 |
* Update regex * Update src/Umbraco.Web.UI.Client/src/common/directives/components/umbavatar.directive.js Co-authored-by: Ronald Barendse <ronald@barend.se> --------- Co-authored-by: Ronald Barendse <ronald@barend.se> (cherry picked from commit 280fbdd) # Conflicts: # src/Umbraco.Web.UI.Client/src/common/directives/components/umbavatar.directive.js
Cherry picked for 10.5 in aacac49 |
In addition to #13766
This PR updated the regex to remove special charachters as suggested by @ronaldbarendse #13766 (comment)
The regex has Unicode mode enabled now.