Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bosnian language #13854

Merged
merged 3 commits into from Feb 21, 2023
Merged

Add Bosnian language #13854

merged 3 commits into from Feb 21, 2023

Conversation

Smayke95
Copy link
Contributor

Translates Umbraco backoffice into Bosnian language, so it can be used by people who doesn't understand English.

This language is fully understandable in countries: Bosnia and Herzegovina, Croatia, Serbia, Montenegro, and partially understandable in Slovenia, Albania and Macedonia. I also can add Croatian and Serbian language but these three languages are 99% same.

Additionally, I fixed a few errors in English translation.

This language can be tested by changing language to Bosnian on user account page.

Screenshots:
01
02
03
04

@github-actions
Copy link

github-actions bot commented Feb 18, 2023

Hi there @Smayke95, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Feb 21, 2023

Hello @Smayke95 ,

Thanks you so much for this new language file! It is great that so many people will be able to see the Umbraco back office in their own language 👍😃

While testing, I noticed that the "packages" page looked a little strange as the display area was very small (see screenshot). I checked with other languages and there the display area looked normal. The only difference I could spot was that, in those other languages, the labels "Packages" were not translated in the menu nor in the title.

Could you maybe check if you have the same behavior as me on your computer, just to make sure that it's not a problem with mine 😅?

Thanks and cheers!

image

@Smayke95
Copy link
Contributor Author

Hi @mikecp

I tested again and found that translation with key "marketplace" inside area "sections" causes this issue. So I reverted this key to original value because it's working only with exact value: Marketplace.

I commited the fix in this PR.

Thanks for finding the bug.

01

@mikecp
Copy link
Contributor

mikecp commented Feb 21, 2023

Thanks @Smayke95 for the quick update!
I figured it had to be about a "hardcoded" label but the question was to find which one😅
Glad you found it 👍

I'll reach out to HQ about this because, if the label HAS TO BE "Marketplace", then it's not really a label and it should not be in the language files IMHO.

I'll wait for the tests to complete and then it'll be ready to merge!

@mikecp
Copy link
Contributor

mikecp commented Feb 21, 2023

Hi again @Smayke95 ,

Let's merge this now! Thanks again for this great addition!
And congratulations on your first contribution to the Umbraco CMS! 🎉
If you provide us with your account name on Our, @nul800sebastiaan will be happy to assign our shiny contributor's badge to you 🥇

And we'll now be looking forward to your next PR 😉

Cheers!

@Smayke95
Copy link
Contributor Author

Smayke95 commented Feb 21, 2023

Hi @mikecp

Thank you for approving my little contribution to Umbraco 😊
I hope that I didn't make a mistake with the naming convention for branch/commit/pr.

My account on Our Umbraco is: https://our.umbraco.com/members/Smayke95/

Thank you.

@nul800sebastiaan
Copy link
Member

Thanks again @Smayke95 for the PR and congrats on your new contrib badge! our.umbraco.com/members/Smayke95🏅

nul800sebastiaan pushed a commit that referenced this pull request Mar 16, 2023
* Add Bosnian language

* fix

* Fix issue with Marketplace

(cherry picked from commit 42d143c)
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.5 in d418d06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants