New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bosnian language #13854
Add Bosnian language #13854
Conversation
Hi there @Smayke95, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hello @Smayke95 , Thanks you so much for this new language file! It is great that so many people will be able to see the Umbraco back office in their own language 👍😃 While testing, I noticed that the "packages" page looked a little strange as the display area was very small (see screenshot). I checked with other languages and there the display area looked normal. The only difference I could spot was that, in those other languages, the labels "Packages" were not translated in the menu nor in the title. Could you maybe check if you have the same behavior as me on your computer, just to make sure that it's not a problem with mine 😅? Thanks and cheers! |
Hi @mikecp I tested again and found that translation with key "marketplace" inside area "sections" causes this issue. So I reverted this key to original value because it's working only with exact value: Marketplace. I commited the fix in this PR. Thanks for finding the bug. |
Thanks @Smayke95 for the quick update! I'll reach out to HQ about this because, if the label HAS TO BE "Marketplace", then it's not really a label and it should not be in the language files IMHO. I'll wait for the tests to complete and then it'll be ready to merge! |
Hi again @Smayke95 , Let's merge this now! Thanks again for this great addition! And we'll now be looking forward to your next PR 😉 Cheers! |
Hi @mikecp Thank you for approving my little contribution to Umbraco 😊 My account on Our Umbraco is: https://our.umbraco.com/members/Smayke95/ Thank you. |
Thanks again @Smayke95 for the PR and congrats on your new contrib badge! our.umbraco.com/members/Smayke95🏅 |
* Add Bosnian language * fix * Fix issue with Marketplace (cherry picked from commit 42d143c)
Cherry picked for 10.5 in d418d06 |
Translates Umbraco backoffice into Bosnian language, so it can be used by people who doesn't understand English.
This language is fully understandable in countries: Bosnia and Herzegovina, Croatia, Serbia, Montenegro, and partially understandable in Slovenia, Albania and Macedonia. I also can add Croatian and Serbian language but these three languages are 99% same.
Additionally, I fixed a few errors in English translation.
This language can be tested by changing language to Bosnian on user account page.
Screenshots: