Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves tooltip issue for block column editor on remove block column editor option #13939

Merged
merged 1 commit into from Mar 9, 2023

Conversation

KamiKunDesu
Copy link
Contributor

@KamiKunDesu KamiKunDesu commented Mar 9, 2023

…ditor option

If there's an existing issue for this PR then this fixes Fixes #13187

Injected the localisation service into the block column edit option and added an ng-attr-title which renders a tooltip for the element in the localised language to the element. Issued solved with @Bakersbakebread

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Hi there @KamiKunDesu, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@JasonElkin JasonElkin self-assigned this Mar 9, 2023
@JasonElkin JasonElkin merged commit 393845c into umbraco:contrib Mar 9, 2023
14 checks passed
@JasonElkin
Copy link
Contributor

Hey there @KamiKunDesu,

Thanks so much for making this bit of the UI friendlier! 🙌

I see this is your first time contributing to the Umbraco CMS, congrats 🎉
If have an account on our.umbraco.com then drop a comment below with your account name and @busrasengul will add a shiny new C-Trib badge to your profile. 🏆

@JasonElkin
Copy link
Contributor

JasonElkin commented Mar 9, 2023

@KamiKunDesu I see you're at the hackathon as well - head over and get the highest of fives from @nul800sebastiaan !

@JasonElkin JasonElkin added category/ux User experience and removed area/frontend labels Mar 9, 2023
@nul800sebastiaan nul800sebastiaan changed the title Solves tooltip issue for block column editor on remove block column e… Solves tooltip issue for block column editor on remove block column editor option Mar 17, 2023
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.5 in 8a3cf27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Block Grid Editor: Remove column span need a tooltip
3 participants