Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where Block Grid elements in areas cannot be properly filtered #13967

Merged
merged 1 commit into from Mar 16, 2023

Conversation

LennardF1989
Copy link
Contributor

We ran into this issue while playing with a NotificationHandler to filter allowed element types.

When vm.availableBlockTypes doesn't contain an element type that an area specifically references, the old code would just add an undefined to the allowedElementTypes. This causes the "add content" overlay to not open anymore.

@github-actions
Copy link

github-actions bot commented Mar 14, 2023

Hi there @LennardF1989, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@LennardF1989
Copy link
Contributor Author

LennardF1989 commented Mar 14, 2023

The CodeScene check failing is not really something I can be held responsible for, since it's already way over the allowed treshold to begin with :P

@mikecp
Copy link
Contributor

mikecp commented Mar 16, 2023

Hi @LennardF1989 ,

Nice catch, and thank you for providing the fix for it 👍

Cheers!

@mikecp mikecp merged commit e10ff16 into umbraco:contrib Mar 16, 2023
@nul800sebastiaan
Copy link
Member

Cherry picked for 10.5 in 9d11401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants