Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14016 Fixed, added cache buster to Block Grid Editor stylesheets #14018

Merged
merged 1 commit into from Apr 15, 2023

Conversation

enkelmedia
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

  1. Create CSS-file in /wwwroot/block-styles.css
  2. Create a new Document Type (Element Type) called "Test Block", add a textbox-property called "Heading"
  3. Create a new Data Type called "Block Grid with Styles", add a block using the content type from step 2. Configure it to use the block-style.css file as "Custom styleheet".
  4. Add a new Document type allowed at root and place the `Block Grid with Styles´-data type to the new document type.
  5. Create a new content node of the new document type and add a Test Block to the Block Grid-editor.

Notice that the request to /wwwroot/block-styles.css now has a cache buster. Cache buster has been added to:

  • Custom stylesheet on block-level
  • Default stylesheet for the whole Block Grid Editor (umbraco-blockgridlayout.css)
  • Custom stylesheet on for the whole Block Grid Editor
  • The blockgridui.css style

image

@github-actions
Copy link

github-actions bot commented Mar 28, 2023

Hi there @enkelmedia, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @enkelmedia !

Thanks for this update to add cache buster to Block Grid Editor stylesheets - we'll make sure someone takes a look at it as soon as possible 🙂

Emma

@lauraneto lauraneto self-assigned this Apr 14, 2023
@lauraneto lauraneto linked an issue Apr 15, 2023 that may be closed by this pull request
@lauraneto lauraneto merged commit 80f6bb4 into umbraco:contrib Apr 15, 2023
14 checks passed
@lauraneto
Copy link
Contributor

Hi @enkelmedia ,

Thanks again for the pull request!
This has now been merged and will be released in 11.4.0. 🙂

@nul800sebastiaan
Copy link
Member

Cherry picked for 10.6 in f9aaf19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No cache buster for stylesheets in Block Grid Editor
5 participants