Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses Issue #12388: When a Block List Editor is the last property on a tab, it's components properties have little to no spacing. #14097

Merged
merged 1 commit into from Apr 14, 2023

Conversation

markadrake
Copy link
Contributor

When a Block List Editor is the last property on a tab, it's components properties have little to no spacing.

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #12388.

Description

  • When the Block List is the last property editor on a tab, and using inline editing, the margin between the properties disappears. There's also a smidge of additional margin at the bottom that could be removed.
  • Minimal changes to LESS were made to address this issue.
  • Please review the backoffice editing experience thoroughly.

Before PR:

image

After PR:

image

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

Hi there @markadrake, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid georgebid self-requested a review April 14, 2023 10:45
@georgebid georgebid self-assigned this Apr 14, 2023
@georgebid
Copy link
Contributor

Hey @markadrake thanks for the PR! I will take a look at this soon :)

@georgebid georgebid merged commit 9a638b6 into umbraco:contrib Apr 14, 2023
14 checks passed
@georgebid
Copy link
Contributor

Looks really nice @markadrake! I have now merged this in and it will feature in release/11.4.0 🎉

@nul800sebastiaan
Copy link
Member

Cherry picked for 10.6 in 539640f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants