[Fix] Block editor labels showing Angular JS on first load.

[dKumarmj]

Prerequisites

The Block Label of Block Components is displaying Angular JS code rather than result on first load. If opened again the label displays correctly

Reported issue #14105

Description

old code

blockObject.label = (blockObject.config.label || blockObject.content?.contentTypeName) ?? "" ;

new code

blockObject.label = (blockObject.labelInterpolator(blockObject.data) || blockObject.content?.contentTypeName) ?? "";

Replace blockObject.config.label with blockObject.labelInterpolator(blockObject.data), because of blockObject.config.label always has the property alias eg: {{propertyAlias}}

[github-actions]

Hi there @dKumarmj, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[nul800sebastiaan]

Thanks @dKumarmj, I think ng-bind-html is a great alternative, especially since the goal was not to do anything very special at all, the goal was:

Assigns the config label as the first instance, if this is not set (left empty) then uses the contenttype name of the block. If that fails, which is unlikely, will default to an empty string to prevent failure elsewhere.

I'd love to give it another test after you make those changes, should be quick to merge then! 👍

[iOvergaard]

@nul800sebastiaan > I think that ng-bind-html is not a good solution, since people expect to be able to use filters for this label, for example, the infamous ncNodeName filter is a good one which needs to work unfortunately.

The latest change on this PR effectually just reverts the change made in the former PR #13937 that broke it in the first place. Personally, I think this is the best we can do, since a computed label does not make sense before you enter any value in the item anyway, so I would recommend that we simply merge this current PR and pick it for v10 and v11.

What do you think?

P.S. We'll try and see how we can improve on this in the new backoffice where we are not subject to the limitations of AngularJS's interpolator 😢

[nul800sebastiaan]

@iOvergaard Sounds good to me! That said, I can't for the life of me reproduce the originally reported behavior reported so I am not sure if maybe something else was also fixed along the way. I'll comment on the other issue as well.

Thanks very much @dKumarmj for the help and your flexibility here! #h5yr 👍

[nul800sebastiaan]

Cherry picked for v10 in 16f448a
Cherry picked for v11 in 7d3c22b

[marcloveUSN]

Hi, this issue should be re-opened. This is still occurring in Umbraco 11.4.0

[Chris-Barber]

This is happening in Umbraco Cloud 10.5.1

[iOvergaard]

@marcloveUSN I just had a look around. Unfortunately, it seems something has gone wrong with the merge and this fix was never included in 11.4.0. I have retagged this to 11.4.1, which is slated for release later this week.

We are very sorry about the confusion and frustration this might have caused.

[iOvergaard]

@Chris-Barber Thanks for testing this. The fix for the version 10 series of Umbraco will be available with version 10.6.0 which is slated for release in the beginning of July.

[marcloveUSN]

@iOvergaard thanks for the update. Glad to hear its now resolved.