Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepUserLoggedIn seems to be ignored #14182

Closed
Behodar opened this issue May 1, 2023 · 5 comments
Closed

KeepUserLoggedIn seems to be ignored #14182

Behodar opened this issue May 1, 2023 · 5 comments
Labels
community/hackathon state/needs-investigation This requires input from HQ or community to proceed type/bug

Comments

@Behodar
Copy link

Behodar commented May 1, 2023

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

10.4.1

Bug summary

appsettings.json has a setting called Umbraco.CMS.Security.KeepUserLoggedIn, which looks like it stops users from being automatically logged out of the back office. It seems that this doesn't work in Umbraco 9/10/11.

There is some discussion of this issue at https://our.umbraco.com/forum/using-umbraco-and-getting-started/108929-keepuserloggedin-v9. The setting worked correctly in Umbraco 7 and 8 (although it was in umbracoSettings.config in those versions).

Specifics

No response

Steps to reproduce

  1. In appsettings.json, set Umbraco.CMS.Security.KeepUserLoggedIn to true.
  2. Log into the back office.
  3. Wait for the timeout (20 minutes?)
  4. Notice that you get logged out.

An easy way of testing this is to log in, then close the browser. Come back later in the day and go to the back office, and it'll ask you to log in again.

Expected result / actual result

I expected to remain logged in.

The documentation doesn't explicitly state what setting the value to true actually does (it only defines what setting it to false does), but it's fair to assume that it would work the same way as it did in Umbraco 7 and 8, i.e. keep the user logged in.

@github-actions
Copy link

github-actions bot commented May 1, 2023

Hi there @Behodar!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@DeadMonkeyX
Copy link
Contributor

I'll be working on this :-)

@nul800sebastiaan
Copy link
Member

We tried to reproduce this at the Codegarden hackathon, but it just worked. For now I'll close this issue but if we have more steps to reproduce we can have another look at it!

@Behodar
Copy link
Author

Behodar commented Jun 16, 2023

I can confirm that this is still an issue in 10.5.1. There was also a comment on this issue from @Zeegaan which seems to have vanished: "I can certainly reproduce this! Interestingly enough, it does seem that the setting reflects back to the front-end" with a screenshot of some JSON with "keepUserLoggedIn": true.

@Zeegaan
Copy link
Member

Zeegaan commented Jun 19, 2023

Yea I thought I had reproduced it, but sadly not 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/hackathon state/needs-investigation This requires input from HQ or community to proceed type/bug
Development

No branches or pull requests

4 participants