Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary CRUD API for content types #14334

Merged
merged 5 commits into from Jun 6, 2023

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Jun 4, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

This is a temporary measure to make us able to create, update and delete content types in the management API (we can already get them by ID).

The implementation is not written to be pretty. Hopefully it will prove as a starting point for "the actual" server side implementation. It is littered with FIXME's to that end.

The API contract on the other hand should be OK, so please pay special attention to reviewing that.

Test that content types can be created, updated and deleted. Try with different permutations of properties and tabs/groups, particularly groups in tabs 馃槃

Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, and it seems to work, although it's super weird that you have to specify a key that is then promptly ignored and regenerated but I'll chuck than in the "future os problem" category :D

@kjac kjac merged commit fe0cbc5 into v14/dev Jun 6, 2023
13 checks passed
@kjac kjac deleted the v14/feature/content-type-temporary-crud branch June 6, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants