Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V12: Use hosting environment to get local temp path #14335

Merged
merged 1 commit into from Jun 5, 2023
Merged

V12: Use hosting environment to get local temp path #14335

merged 1 commit into from Jun 5, 2023

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Jun 5, 2023 •
edited

Notes

  • use IHostingEnvironment to get the local temp path, instead of a static one, as we can configure that path via appsettings

How to test

  • Configure temp path in AppSettings.Json
"Hosting": {
  "LocalTempStorageLocation": "EnvironmentTemp"
},
  • Run Umbraco and create a document type with some content to trigger a nucache build
  • Upgrade to this branch, and assert the NuCache files get deleted (if you started on this branch, just duplicate the line running this migration in UmbracoPlan and enter a new GUID instead)

@Zeegaan Zeegaan merged commit 6073662 into v12/dev Jun 5, 2023
16 checks passed
@Zeegaan Zeegaan deleted the v12/bugfix/find-variable-temp-folder-path branch June 5, 2023 08:56
Zeegaan added a commit that referenced this pull request Jun 5, 2023
@Zeegaan
Use hosting environment to get local temp path (#14335)
c65f22a
@Zeegaan
Copy link
Member Author

Zeegaan commented Jun 5, 2023

Cherry picked for the release branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmania bergmania bergmania approved these changes

Assignees
No one assigned
Labels
release/12.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zeegaan @bergmania