Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Danish translation for general_change #14461

Merged
merged 2 commits into from Jun 27, 2023

Conversation

abjerner
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Umbraco's umbNodePreview directive supports a change action, but the label doesn't have a Danish translation, so it falls back to the English Change, which can seem a bit odd to the user as the other labels related to umbNodePreview are translated.

This PR therefore adds a the general_change key the Danish language file (da.xml) with the value Skift.

The key is actually also missing in the English language file (en_us.xml), but the English label is still showed correctly as a fallback label is specified in the Angular view. So this PR also adds the general_change key to en_us.xml with the value Change. This way, it should hopefully be easier to see that the translation is missing in other languages.

image

image

@github-actions
Copy link

Hi there @abjerner, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid georgebid self-requested a review June 27, 2023 13:26
@georgebid
Copy link
Contributor

Thanks for the PR @abjerner! Someone on the core collaborators team will review this soon 😸

@georgebid georgebid merged commit a090997 into umbraco:contrib Jun 27, 2023
14 checks passed
@georgebid
Copy link
Contributor

Hey again! I have tested this and I can now see the translations applying where necessary. Therefore I have merged this one in. Thanks @abjerner 🥳

nul800sebastiaan pushed a commit that referenced this pull request Jul 4, 2023
* Added missing Danish translation for `general_change`

* Update en_us.xml

(cherry picked from commit a090997)
@nul800sebastiaan
Copy link
Member

Cherry picked for v10/11 in 3087fc3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants