Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: Skip and take updates #14478

Merged
merged 6 commits into from Jun 29, 2023
Merged

V14: Skip and take updates #14478

merged 6 commits into from Jun 29, 2023

Conversation

elit0451
Copy link
Member

Details

  • Aligning on skip and take for pagination between our controllers.

Note
At the moment, some controllers don't allow for: for example ?skip=1&take=100, because we have to refactor our services to work with skip and take instead of pageNumber and pageSize;
Like:

  • /audit-log?skip=1&take=100 - throws 500 error;
  • /culture?skip=1&take=100 - works.

Test

  • The changes aren't really changing the functional behaviour so there isn't really anything to test...
    • Maybe just verify that /audit-log endpoint (CurrentUserAuditLogController.cs) works as expected, with the correct skip and take relation, (like skip = 4, take = 2, or skip = 10, take = 5) as there used to be double pagination. 😉

@elit0451 elit0451 added the project/bellissima AKA "the new backoffice" label Jun 29, 2023
@Zeegaan
Copy link
Member

Zeegaan commented Jun 29, 2023

LGTM 🚀

@Zeegaan Zeegaan merged commit cdfae0c into v14/dev Jun 29, 2023
12 of 13 checks passed
@Zeegaan Zeegaan deleted the v14/bugfix/skip-and-take-updates branch June 29, 2023 10:33
@iOvergaard iOvergaard removed the project/bellissima AKA "the new backoffice" label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants