Do not allow content type property aliases that conflict with IPublishedElement #14683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, tests good 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
It is currently possible to define content type properties with aliases that conflict with
IPublishedElementproperties - e.g.ContentTypeandProperties. This becomes a problem when ModelsBuilder creates strongly typed models:We're already trying to avoid this scenario in the server side validation. However, we're only testing for properties and methods defined on
IPublishedContent.With this PR we also test properties from base interfaces like
IPublishedElement. Now we can no longer create properties with clashing aliases:Note that the
TypeExtensionschanges in this PR have been copied over from similar changes in a V14 PR, thus adding more new extension methods than strictly necessary for this PR. This hopefully will make forward merging easier 😄