Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensured that allowed user name characters are supported in backo… #14810

Merged
merged 1 commit into from Sep 18, 2023

Conversation

bielu
Copy link
Contributor

@bielu bielu commented Sep 15, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

Description

Partially fix: #14808

Test steps:

  1. set UsernameIsEmail to false
  2. set AllowedUserNameCharacters to include space
  3. create user with name containing a space in login
  4. try to change password / unlock / disable user
  5. you will get user correctly updated

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Hi there @bielu, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@emmagarland
Copy link
Contributor

Hi @bielu,

Thanks for your PR to partially fix #14808, to allow a change of password for users with a space in their name.

May I check when you say partially fix, what would be remaining in #14808? Would it be sub-bug 1 you put in the issue?

Thanks, and one of the Core Collaborators team will review this as soon as possible.

Best wishes

Emma

@bielu
Copy link
Contributor Author

bielu commented Sep 18, 2023

@emmagarland subbug 1 remaining after merging as it is bigger change. This PR fix subbug 2, as steps test step describing :)

@Zeegaan
Copy link
Member

Zeegaan commented Sep 18, 2023

Looks good, tests good 🎉

@Zeegaan Zeegaan merged commit 86697ff into umbraco:contrib Sep 18, 2023
14 checks passed
Zeegaan pushed a commit that referenced this pull request Sep 18, 2023
@Zeegaan Zeegaan mentioned this pull request Sep 18, 2023
Zeegaan added a commit that referenced this pull request Sep 19, 2023
…ffice users as well (#14810) (#14825)

Co-authored-by: Arkadiusz Biel <bielu@bielu.com.pl>
@emmagarland
Copy link
Contributor

emmagarland commented Oct 5, 2023

Thanks for the reply, @bielu. One of the team will get onto this as soon as possible.

[EDIT] Looks like we already have! Nice one :)

Emma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Umbraco allows usernames with spaces but doesnt allow change password for this users
3 participants