New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensured that allowed user name characters are supported in backo… #14810
Conversation
…ffice users as well
Hi there @bielu, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @bielu, Thanks for your PR to partially fix #14808, to allow a change of password for users with a space in their name. May I check when you say partially fix, what would be remaining in #14808? Would it be sub-bug 1 you put in the issue? Thanks, and one of the Core Collaborators team will review this as soon as possible. Best wishes Emma |
@emmagarland subbug 1 remaining after merging as it is bigger change. This PR fix subbug 2, as steps test step describing :) |
Looks good, tests good 🎉 |
…ffice users as well (#14810)
Thanks for the reply, @bielu. One of the team will get onto this as soon as possible. [EDIT] Looks like we already have! Nice one :) Emma |
Prerequisites
If there's an existing issue for this PR then this fixes
Description
Partially fix: #14808
Test steps: