Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up V14 TODOs from ContentApiItemControllerBase #15026

Merged
merged 1 commit into from Oct 24, 2023

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Oct 24, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

When implementing member auth in the V14 branch, a few things were marked for V14 obsoletion in ContentApiItemControllerBase, but they were not removed from the source. This was in order to make the backport and subsequent forward merge less conflicting.

Now that the backport and forward merge is done, this PR removes the obsoleted parts of ContentApiItemControllerBase.

Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪 Merging

@elit0451 elit0451 merged commit b7a1cd5 into v14/dev Oct 24, 2023
15 checks passed
@elit0451 elit0451 deleted the v14/fix/clean-up-content-api-controller-base branch October 24, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants