Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data type icons should not be served from the Management API #15155

Merged

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Nov 7, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The server should not know about data type icons in V14, so the Management API should not be serving them 😄 instead, the client needs the editor UI alias to handle data type icons, groups etc. etc.

Testing this PR

  1. Verify that the data type tree endpoints return editor UI alias instead of icon for the data type tree items returned.
  2. Verify that the data type item endpoints return editor UI alias instead of icon for the data type items returned.

Copy link
Contributor

@Migaroez Migaroez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tests good
  • Code looks good
  • No new warnings

@Migaroez Migaroez merged commit 589c74e into v14/dev Nov 10, 2023
14 checks passed
@Migaroez Migaroez deleted the v14/fix/data-type-icon-does-not-belong-on-the-server branch November 10, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants