V13: Refactor webhookservice to attempt pattern #15180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Notifications was introduced in #15174, and with it came cancelling by notification 👀
This meant that you could cancel Save/Delete operations, but the frontend did not match!
For example, if you canceled deleting a webhook, the controllers would return 200 OK, and thus the frontend would think that you had deleted the entity and thus remove it from your screen. It would only come back after a refresh.
This PR remedies that by implementing the attempt pattern also seen in
v14
, and with the OperationStatus, now returns the correct status codes & notifications 🚀How to test
WebhookNotificationsComposer
This should also be tested with creating / updating, this can be done by moving around the
notification.CancelOperation(new EventMessage("", ""));
in theWebhookNotificationsComposer
.WebhookNotificationsComposer