V14: Don't add published culture infos if not published #15370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-unpublishing-cultures-still-persists
…still-persists # Conflicts: # tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentPublishingServiceTests.Publish.cs
bergmania
approved these changes
Jan 31, 2024
bergmania
deleted the
v14/bugfix/content-unpublishing-cultures-still-persists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Problem right now is that when we
Unpublisha single culture, that re-published the content, but just without the "unpublished" culture.When we unpublish all cultures, it works a bit different though. We don't unpublish the cultures. We just unpublished the content itself, and thus the cultures are not routable.
Problem is though the
content.PublishedInfosstill containted the "Published" cultures.This PR remedies that by now publishing all cultures instead.
How to test