Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13: Log webhook firing exceptions when they happen #15393

Merged
merged 2 commits into from Dec 7, 2023

Conversation

Zeegaan
Copy link
Member

@Zeegaan Zeegaan commented Dec 7, 2023

Notes

  • Refactors WebhookLog factory to not take WebhookResponse model, but instead Request & Response, so we can always log request.
  • Adds ExceptionOccured property to webhook log, so we can display it in the backoffice

How to test

  • Create doc type
  • Create webhook with URL https://some.where/
  • Select Content Published event
  • Create some content with doc type from step 1.
  • Go to webhook logs, this should now display your error in the response body, and still link you to the logs for more details.

@andr317c
Copy link
Contributor

andr317c commented Dec 7, 2023

Looks good tests gooder 🚀

@andr317c andr317c merged commit b50353b into release/13.0 Dec 7, 2023
14 checks passed
@andr317c andr317c deleted the v13/feature/log-exceptions-when-they-happen branch December 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants