Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health checks results to payload #15485

Conversation

erikjanwestendorp
Copy link
Contributor

@erikjanwestendorp erikjanwestendorp commented Dec 19, 2023

Prerequisites

  • I have added steps to test this contribution in the description below

Description

Update the HealthCheckCompletedWebhookEvent. Add the health check results to the payload.

Before:
image

After:
image

Test:

  • Add a composer
public class WebhookComposer : IComposer
{
    public void Compose(IUmbracoBuilder builder)
    {
        builder.WebhookEvents().AddCms();
    }
}
  • Configure a Health Check Completed webhook:

image

  • Run one or multiple health checks

Copy link

github-actions bot commented Dec 19, 2023

Hi there @erikjanwestendorp, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid
Copy link
Contributor

Hey @erikjanwestendorp thanks a lot for your PR, someone on the core collaborators team will review this soon 😸

@busrasengul
Copy link
Contributor

Hey @erikjanwestendorp, I tested this and it does work, although the json data comes back within response and the structure doesn't fully match what you share, mind that, there have been some changes since this PR.
So would you be able to sync this PR with the latest state and test it again for me, if I'm doing something wrong or the response I'm seeing is correct?
image
Thank you :)

@erikjanwestendorp
Copy link
Contributor Author

@busrasengul Thanks for your review! Updated the PR. contrib is merged to this branch.

@busrasengul
Copy link
Contributor

Thank you @erikjanwestendorp
Let's get this merge in!

@busrasengul busrasengul merged commit ce769ff into umbraco:contrib Mar 5, 2024
11 of 13 checks passed
@busrasengul busrasengul self-assigned this Mar 5, 2024
@erikjanwestendorp erikjanwestendorp deleted the update-health-check-completed-webhook-event branch March 5, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants