"Created at" responses should not have a response body #15590
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Currently the "Created at" responses from the Management API contain a response body with
"null"
. Turns out the built-inCreatedAtActionResult
is built uponObjectResult
, which outputsnull
values in the response body.The
"null"
response is messing with the new back-office client.To work around this, a new
EmptyCreatedAtActionResult
has been added to theApi.Common
, and this is then used for all "Created at" responses created by Management API base controller.The
EmptyCreatedAtActionResult
is purposely placed inApi.Common
and made public (sealed), so it can be reused in other APIs.Testing this PR
"Created at" responses are built in different ways depending on the action performed. To test this PR, verify that the following API operations return a HTTP201 status code, and that the response a correct location header: