Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTE content is no longer indexed when used on an element in the block list editor #15654

Closed
ptilsed opened this issue Jan 31, 2024 · 5 comments
Closed

Comments

@ptilsed
Copy link

ptilsed commented Jan 31, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.0.3

Bug summary

After upgrading a site to V13 we've noticed that the RTE content found in element types added to a content block list no longer seems to be added to the examine index correctly.

Specifics

This issue appears to be related to the RTE datatype now being stored in JSON format within the block list data where as previously it was stored as the raw HTML:

image
V12

image
V13

This change seems to result in the JsonPropertyIndexValueFactoryBase class being used to index the content which is returning an empty string when attempting to index the content of the RTE.

Other property types such as text areas and textbox's are being indexed correctly so this seemed limited to the RTE. This property normally contains most of the useful indexable content however so it's impact on the search is quite high.

Steps to reproduce

Spin up a new V13 install and create an element type that consists of a RTE property, enable it on a block list editor that is found on any published pages that should be indexed. Add some content and check if the RTE value is added to the any of the examine indexes.

Expected result / actual result

The content stored in an RTE used on an element type added to a block list should be indexed as it was in previous versions

Copy link

Hi there @ptilsed!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@BillyDigi
Copy link

I'm also having this issue after upgrading a project to v13.
Asked around on the forums (https://our.umbraco.com/forum/using-umbraco-and-getting-started/113499-block-grid-not-indexing-rich-text-editors) but had no reply yet.

I'll keep an eye on this issue, hope the team picks it up asap.

@Migaroez
Copy link
Contributor

Migaroez commented Feb 1, 2024

Hey Paul, Thank you for bringing this to our attention. I have confirmed this is still the the case for 13.1.0 and it looks like a nasty regression bug, we will pick this up asap

@ptilsed
Copy link
Author

ptilsed commented Feb 1, 2024

@Migaroez Thanks for the update, it had us digging around for a while but glad it's been the tracked down and the fix looks pretty straight forward.

@Migaroez
Copy link
Contributor

Migaroez commented Feb 1, 2024

Thank you for pointing me in the right direction, which meant I could fix it easily!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants