V14: Migrate nucache to use System.Text.Json #15685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem-text-for-nucache
elit0451
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates NuCache to use
System.Text.Jsoninstead ofNewtonsoft.Json.There were quite a few performance optimizations around this area, some of which I've reimplemented, however, some do not seem possible for
System.Text.Json, so I've skipped these, it should still be fine though since it's recommended to use messagepack anyways.Testing
On V14/dev, configure the solution to use JSON for NuCache:
Create some content on V14/dev, preferably something fairly complex, and render it on the frontend
Switch over to this branch and ensure that the content still loads from the cache and renders.