V13: The login screen does not display external login errors #15715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression compared from V12 to V13 where the new login screen UI did not show external login errors that happened on the server side. The is two-fold:
BackOfficeController
needed to have its built-in error messages migrated from V12, and theUmbracoLogin/Index.cshtml
needed to hook on to those errors and forward them to the login screen UI.Fixes #15622
How to test
Set a cookie containing external login errors somewhere, e.g. in the BackOfficeController:
Verify that the error message shows up on the login screen below the welcome message.